Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry Run and tests #878

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Dry Run and tests #878

merged 5 commits into from
Nov 25, 2024

Conversation

janboll
Copy link
Collaborator

@janboll janboll commented Nov 22, 2024

What this PR does

  • Add the capability to run dry runs on shell script steps.
  • Did some slight refactorings to add tests.
  • Also moved AKS Kubeconfig creation into Resource group to only call it once, as it is not required to run it for every stip since it can be reused

Jira:
Link to demo recording:

Special notes for your reviewer

tooling/templatize/testdata/pipeline.yaml Outdated Show resolved Hide resolved
tooling/templatize/pkg/pipeline/run.go Outdated Show resolved Hide resolved
Add the capability to run dry runs on shell script steps.
Did some slight refactorings to add tests.
Also moved AKS Kubeconfig creation into Resource group to only call it once, as it is not required to run it for every stip since it can be reused
@janboll janboll changed the title WIP Dry Run Dry Run and tests Nov 25, 2024
@janboll janboll marked this pull request as ready for review November 25, 2024 10:24
dryRun:
envVars:
- name: DRY_RUN
value: "A very dry one"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@janboll janboll merged commit 228914f into main Nov 25, 2024
18 checks passed
@janboll janboll deleted the add-some-more-tests branch November 25, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants